Read-only mounts not working

Erwin Lansing erwin at FreeBSD.org
Sat Oct 7 06:20:02 EDT 2006


Hi,

While debugging yet another "modifying read-only filesystem" from
pointyhat, I found a small typo in tinderbox_shlib.sh that prevents
read-only mounts from working at all.  This only affects the
TINDERBOX_2_X branch as it is not present in HEAD tinderlib.sh.
Patch attached.

-erwin

-- 
Erwin Lansing                                     http://droso.org
Security is like an onion.          (o_ _o)
It's made up of several layers   \\\_\   /_///
And it makes you cry.            <____) (____>    erwin at lansing.dk
-------------- next part --------------
Index: tinderbox_shlib.sh
===================================================================
RCS file: /space/cvs/marcuscom-cvs/portstools/tinderbox/lib/Attic/tinderbox_shlib.sh,v
retrieving revision 1.18.2.1
diff -u -r1.18.2.1 tinderbox_shlib.sh
--- tinderbox_shlib.sh	27 Nov 2005 18:36:34 -0000	1.18.2.1
+++ tinderbox_shlib.sh	7 Oct 2006 10:14:23 -0000
@@ -304,7 +304,7 @@
 	fi
 
 	if [ ${_readonly} -eq 1 ] ; then
-		options="${_options} -r"
+		_options="${_options} -r"
 	fi
 
 	mount ${_options} ${_source} ${_destination}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://marcuscom.com/pipermail/tinderbox-list/attachments/20061007/05d10239/attachment.bin 


More information about the tinderbox-list mailing list