2 patches (world -j and some more fail reasons)

[Philip M. Gollucci]

Joe Marcus Clarke wrote:
> On Fri, 2008-12-26 at 18:00 -0500, Philip M. Gollucci wrote:
>> Hi All,
>>
>> 1)
>> in makeBuild()
>>    ..
>>    make world
>>    ..
>>
>> we can safely specify -j whatever here since we know we can with usual world 
>> process. Interestingly, I don't have a uni processor system to test this on,
>> is the sysctl still present but 1 there ?
>>
>> http://people.freebsd.org/~pgollucci/diffs/tc_command.sh.diff
> 
> Yes.
Okay so then this is good right, I don't have access :)

> 
>> 2)
>> Before I dive into this 'apache@' work:
>> I didn't bump __DSVERION__ b/c the comments talk about major, minor, and micro
>> yet the version is only 2 digits not a tuple. So don't forget that.
>>
>> http://people.freebsd.org/~pgollucci/diffs/sql.diff
> 
> This needs a micro DSVERSION bump.  All failure pattern changes should
> be floated up through portmgr, and probably linimon for inclusion in
> pointyhat.
Yes, the question was what is micro version bump ?  The comments talk about 
tuples, but the value is a duple.
3.0.1
3.1

I'll send this ti portmgr@ in a minute.

>> 3)
>> A further optimization to makeBuild above is to detect if the build dir 
>> already exists(aka initial createJail), if not, then you can add -DNO_CLEAN
>> safely.
> 
> This might be made optional as even when a source directory exists,
> -DNO_CLEAN may fail.
I think you read that wrong, I only want to add it if the build dir does NOT 
exist in which case there is nothing to clean. So you can sakely skip it.


-- 
------------------------------------------------------------------------
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70  3F8C 75B8 8FFB DB9B 8C1C
Philip M. Gollucci (pgollucci at p6m7g8.com) c: 703.336.9354
Consultant          - P6M7G8 Inc.                http://p6m7g8.net
Director IT         - RideCharge, Inc.           http://ridecharge.com
Contractor          - PositiveEnergyUSA          http://positiveenergyusa.com
ASF Member          - Apache Software Foundation http://apache.org
FreeBSD Committer   - FreeBSD Foundation         http://freebsd.org

Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.