2 patches (world -j and some more fail reasons)
Joe Marcus Clarke
marcus at marcuscom.com
Fri Dec 26 19:45:52 EST 2008
On Fri, 2008-12-26 at 18:40 -0500, Philip M. Gollucci wrote:
> Joe Marcus Clarke wrote:
> > On Fri, 2008-12-26 at 18:00 -0500, Philip M. Gollucci wrote:
> >> Hi All,
> >> 1)
> >> in makeBuild()
> >> ..
> >> make world
> >> ..
> >> we can safely specify -j whatever here since we know we can with usual world
> >> process. Interestingly, I don't have a uni processor system to test this on,
> >> is the sysctl still present but 1 there ?
> >> http://people.freebsd.org/~pgollucci/diffs/tc_command.sh.diff
> > Yes.
> Okay so then this is good right, I don't have access :)
You're probably safer using hw.ncpu. This will return 1 on a UP system.
> >> 2)
> >> Before I dive into this 'apache@' work:
> >> I didn't bump __DSVERION__ b/c the comments talk about major, minor, and micro
> >> yet the version is only 2 digits not a tuple. So don't forget that.
> >> http://people.freebsd.org/~pgollucci/diffs/sql.diff
> > This needs a micro DSVERSION bump. All failure pattern changes should
> > be floated up through portmgr, and probably linimon for inclusion in
> > pointyhat.
> Yes, the question was what is micro version bump ? The comments talk about
> tuples, but the value is a duple.
It's a double now because we haven't needed a micro version bump. It
will need to go to 3.1.1.
> I'll send this ti portmgr@ in a minute.
> >> 3)
> >> A further optimization to makeBuild above is to detect if the build dir
> >> already exists(aka initial createJail), if not, then you can add -DNO_CLEAN
> >> safely.
> > This might be made optional as even when a source directory exists,
> > -DNO_CLEAN may fail.
> I think you read that wrong, I only want to add it if the build dir does NOT
> exist in which case there is nothing to clean. So you can sakely skip it.
Ah, yes, I did misread. This should be fine.
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 195 bytes
Desc: This is a digitally signed message part
More information about the tinderbox-list