$with_timer bug exposed with paefchen template

[Joe Marcus Clarke]

On Tue, 2008-01-22 at 18:39 +0100, Aron Schlesinger wrote:
> Am 22.01.2008 um 06:23 schrieb Ade Lovett:
> > The timer code (called if you set $with_timer=1) is in the wrong
> > place, appearing after </body></html> in the generated output from
> > either the default template code, or the new paefchen version.
> 
> The problem is buried in the index.php. First, the templates.
> Thereafter, until the time chosen.
> 
> > [..html..]
> >
> > Interestingly, with the default template, the timer code is actually
> > rendered with both Safari and Firefox, but not with the new one.
> 
> templates/paefchen/tinderstyle.css
> 
> /* XXX */
> body > p {
>      display             : none;
> }
> 
> Yes is a dirty "fix".
> 
> > The issue is certainly more a case of the with_timer code being in the
> > wrong place than the defaults.
> > [perl foo ;-)]
> 
> As attachment a quick way to fix in both templates.

I actually had the idea to avoid touching the templates, and just
replace </body> in $display with the necessary text.  If we're going to
touch the templates, would it not be better to make worktime a template
variable and avoid the substitution (though I line where you put the
"cookies required" message)?

Joe

> 
> 
> 
> _______________________________________________
> tinderbox-list at marcuscom.com mailing list
> http://marcuscom.com/mailman/listinfo/tinderbox-list
> To unsubscribe, send any mail to "tinderbox-list-unsubscribe at marcuscom.com"
-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part
Url : http://marcuscom.com/pipermail/tinderbox-list/attachments/20080122/47efbde5/attachment.bin