$with_timer bug exposed with paefchen template
Joe Marcus Clarke
marcus at marcuscom.com
Fri Jan 25 15:15:20 EST 2008
On Fri, 2008-01-25 at 03:09 -0800, Ade Lovett wrote:
> On Jan 22, 2008, at 10:53 , Joe Marcus Clarke wrote:
> > I actually had the idea to avoid touching the templates, and just
> > replace </body> in $display with the necessary text. If we're going
> > to
> > touch the templates, would it not be better to make worktime a
> > template
> > variable and avoid the substitution (though I line where you put the
> > "cookies required" message)?
> I agree. Fixing the templates is not really the way to go. After
> all, should someone develop another template in the future, the same
> hack will have to be applied.
> This really needs to be fixed in the core PHP code.
I sort of compromised. It can really be fixed in the core code without
touching the templates AND make it so the templates can be as crazy as
they want to be. Instead of doing a regexp replacement hack, I turned
the elapsed UI timer into a template variable which works like any other
The code that calculates whether or not to generate the timer, and what
the value of that time will be is in the module and core sections.
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 195 bytes
Desc: This is a digitally signed message part
Url : http://marcuscom.com/pipermail/tinderbox-list/attachments/20080125/aa179edb/attachment.bin
More information about the tinderbox-list