tbcleanup feature requests :)

[Ion-Mihai Tetcu]

On Wed, 09 Jul 2008 17:34:42 -0400
Joe Marcus Clarke <marcus at marcuscom.com> wrote:

> On Wed, 2008-07-09 at 10:58 +0300, Ion-Mihai Tetcu wrote:
> 
> > - have build_ports.Last_Fail_Reason exported to postPortBuild Hook
> > - I need it for setting a relevant subject to the BotmMail; right
> > now $STATUS only gives me SUCCESS, FAIL and DUDS.
> 
> I just did this in HEAD.

Any chance of MFC?

> > - have a little better failure patterns, especially for ports that
> > fail because they need kernel sources. I'm willing to go in in all
> > ports and change the failure message to be the same (like 'This
> > port requires the kernel source be available') and to fail in the
> > same make target if this would help (maybe this could even be
> > implemented via a KNOB in b.p.m).
> 
> I need to re-sync the failure patterns with pointyhat.  

:-) again, MFC? I'm reluctant to use HEAD for QA Tindy esp. since I
plan to enable completely automatic BotMails.

BTW, any ETA for the next release (from HEAD)?

> But if you'd like to add a definitive message to the ports system,
> that would be great.

Well, I think there are enough ports that need the sources to be
installed to warrant a knob in b.m.p

> > I'm a little bit at lost how to implement differentiating between
> > "regular" and commit triggered builds/errors. The thing is I have to
> > send a BotMail each time a port is touched by a commit and it fails,
> > but not for the ports that fail because of my regular builds or
> > because they are dependencies of an other port (else some people
> > would receive a few dozens emails per day about the same port).
> > Right now I queue regular port builds with priority 9 and
> > commit-triggered builds with priority 5. Maybe it would be possible
> > to export this to the postPortBuild hook? Any suggestion is
> > welcomed.
> 
> I suppose it would be possible to export the CLI arguments passed to
> tinderbuild on the command line to related Hooks.  Would this be
> acceptable?

I guess so. I'm querying mysql directly now (which happens to be faster
that getting the results from ./tc) so this is not something I really
need.

BTW, ports_build_queue.Enqueue_Date is set only if the port was queued
via the web interface and not via CLI. Is this by design?


Question: Is ports_build_queue.Build_Ports_Queue_Id being reset (since
it's auto_increment) in any case (like when running tbcleanup)? I need
to keep some other info related to each queue entry in an other table
so I need to know if I can depend on it or not.


Thanks,

-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"
FreeBSD committer -> itetcu at FreeBSD.org, PGP Key ID 057E9F8B493A297B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://marcuscom.com/pipermail/tinderbox-list/attachments/20080710/50d662bd/attachment.bin>