Last_Failed_Dependency

[Joe Marcus Clarke]

On Sun, 2008-06-08 at 18:51 +0300, Ion-Mihai Tetcu wrote:
> Hi,
> 
> What's the reason build_ports.Last_Failed_Dependency isn't set to NULL
> after the port is successfully built ?
> 
> I added this ugly hack in function getPortsForBuild() from
> www-exp/core/TinderboxDS.php:
> 	if ($sortby == "Last_Fail_Reason") {
> 		$sortby = "Last_Fail_Reason, $sortbytable.Last_Failed_Dependency desc";
> 	}
> in order to get the ports failed because of a dependency listed
> together, but not having it reset to NULL kinda breaks it in the output.

The reason for this is because of the following.  Assume port Y depends
on port X.  Port X fails to build, so port Y is not built.  Y's status
is updated to indicate that it depends on failed port X.  On the next
pass, X is built successfully, but Y has not bee built yet.  Therefore,
its last status is still valid: it was not built because it depends on
previously failed port X (i.e. we are preserving the history).

If you wanted to find out which ports were not built because they depend
on a port which is STILL failing to build, you'd have to get the
Last_Failed_Dependency, then check the current status of that port to
see if it is still showing a failure.

Joe

-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part
URL: <http://marcuscom.com/pipermail/tinderbox-list/attachments/20080608/6c70e952/attachment.bin>