Last_Failed_Dependency

[Ion-Mihai Tetcu]

On Sun, 08 Jun 2008 18:58:54 -0400
Joe Marcus Clarke <marcus at marcuscom.com> wrote:

> On Sun, 2008-06-08 at 18:51 +0300, Ion-Mihai Tetcu wrote:
> > Hi,
> > 
> > What's the reason build_ports.Last_Failed_Dependency isn't set to NULL
> > after the port is successfully built ?
> > 
> > I added this ugly hack in function getPortsForBuild() from
> > www-exp/core/TinderboxDS.php:
> > 	if ($sortby == "Last_Fail_Reason") {
> > 		$sortby = "Last_Fail_Reason, $sortbytable.Last_Failed_Dependency desc";
> > 	}
> > in order to get the ports failed because of a dependency listed
> > together, but not having it reset to NULL kinda breaks it in the output.
> 
> The reason for this is because of the following.  Assume port Y depends
> on port X.  Port X fails to build, so port Y is not built.  Y's status
> is updated to indicate that it depends on failed port X.  On the next
> pass, X is built successfully, but Y has not bee built yet.  Therefore,
> its last status is still valid: it was not built because it depends on
> previously failed port X (i.e. we are preserving the history).

Yes, this makes sense. 

But I'm talking about the moment when X has been built OK, then Y has
been built OK.
http://t64.tecnik93.com/index.php?action=list_buildports&build=7-STABLE-FTP&sort=Last_Fail_Reason
devel/gvfs - which failed because sysutils/fusefs-kmod; I built
sysutils/fusefs-kmod by hand, added to the tindy then rebuilt gvfs,
then looked at the DB and sysutils/fusefs-kmod is still listed for gvfs
(which is obvious in the link above).


Thanks,

-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"
FreeBSD committer -> itetcu at FreeBSD.org, PGP Key ID 057E9F8B493A297B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://marcuscom.com/pipermail/tinderbox-list/attachments/20080609/49a31fd1/attachment.bin>