bugish: port not being rebuilt

[Ion-Mihai Tetcu]

Hi,


If a package for the current PKGNAME exists but the entry in the
database is "uninitialized", the port won't be rebuilt by tinderd and
no error will be shown anywhere. 
This happens both with 2.x and latest 3.x releases; with
tinderd_flags="--nullfs" (and irrespective of tinderd_flags containing
"-plistcheck -onceonly" or not).
The same is true if the port is build via tinderbuild.

How to reproduce:
- build a port
- reset the port entry in build_ports table:
update build_ports set last_built=NULL, last_status='UNKNOWN', last_fail_reason='__nofail__', last_successful_built=NULL, last_built_version=NULL, last_failed_dependency=NULL, last_run_duration=NULL, total_size=NULL where Port_Id = N and Build_Id=M;
- add the port to the queue (either reset the status via web interface,
or via an update in the database; or just add it again via
addBuildPortsQueueEntry or an insert in the database).
- wait for tinderd to run

You will see:
- the queue entry having status='SUCCESS', nothing modified in the
build_ports table, the same old package in the packages/BUILD/All/
directory
- only builds/BUILD/Makefile is generated (duds, make.0 and make.1
have size 0)

I have a feeling this situation (existent up-to-date package,
uninitialized entry in the DB) can happen after an Tindy upgrade.


Marcus, it would be very nice to have some more debugging logs and I'd
very much love to see all the logs in one place. tail(1)'ing all the logs
Tindy now produces is rather inconvenient; having them all copied also
in TINDERD_LOGFILE (eventually as an option) would make debugging much
easier (I spent quite some time figuring this out, and I only saw it
because I have a postPortBuild hook that I noticed didn't run).


===Tinderd build of math/spooles on 7-STABLE-FPT starting at Wed Nov 26 11:31:38 PST 2008===
tinderbuild: creating makefile...
tinderbuild: Creating build directory for 7-STABLE-FPT
7-STABLE-FPT: cleaning out /usr/local/tinderbox/7-STABLE-FPT
*** FAILED (rm /usr/local/tinderbox/7-STABLE-FPT)
makeBuild: extracting jail tarball
tinderbuild: Finalizing chroot environment
tinderbuild: 7-STABLE-FPT: Setting up ccache
Set cache size limit to 62914560k
================================================
building packages (phase 0)
================================================
started at Wed Nov 26 11:31:44 PST 2008
ended at Wed Nov 26 11:31:44 PST 2008
phase 0 took 00:00:00
10710 packages built
18G  of packages
================================================
building packages (phase 1)
================================================
started at Wed Nov 26 11:31:44 PST 2008
ended at Wed Nov 26 11:31:45 PST 2008
phase 1 took 00:00:01
10710 packages built
18G  of packages
tinderbuild: Cleaning up after tinderbuild.  Please be patient.

===Tinderd build of math/spooles on 7-STABLE-FPT ending at Wed Nov 26 11:31:46 PST 2008===

root(itetcu)@release/T >-SSH-> /home/itetcu/bin [11:26:41] 0
 # grep tinder /etc/rc.conf*
/etc/rc.conf.local:tinderd_enable="yes"
/etc/rc.conf.local:tinderd_directory="/usr/local/tinderbox/scripts"
/etc/rc.conf.local:tinderd_flags="-nullfs"
root(itetcu)@release/T >-SSH-> /home/itetcu/bin [11:29:41] 0
 # /usr/local/tinderbox/scripts/tc configGet
CCACHE_DIR=/ccache
CCACHE_ENABLED=1
CCACHE_JAIL=0
CCACHE_LOGFILE=
CCACHE_MAX_SIZE=60G
CCACHE_NOLINK=1
DISTFILE_CACHE=/usr/ports/distfiles/
DISTFILE_URI=
HOST_WORKDIR=
OPTIONS_DIR=
OPTIONS_ENABLED=0
TINDERD_LOGFILE=/tmp/tinderd.log
TINDERD_SLEEPTIME=15
__DSVERSION__=3.1



-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"
FreeBSD committer -> itetcu at FreeBSD.org, PGP Key ID 057E9F8B493A297B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://marcuscom.com/pipermail/tinderbox-list/attachments/20081126/2d2ac931/attachment.bin>