Feature Request: -O needs more work

[Joe Marcus Clarke]

On Fri, 2008-09-12 at 14:02 +0200, Frank Wall wrote:
> Hi,
> 
> > * A new -O option has been added to addPort/rescanPorts which enables
> > OPTIONS, but does not run rmconfig before calling config.  This way,
> > existing OPTIONS can be preserved.  The default behavior is to call
> > rmconfig to maintain POLA.
> 
> lately I was adding more ports to my tinderbox again and found
> that the new -O switch does not really cover all aspects of the
> original problem. 
> 
> Let's take a look at an example... I've added mail/roundcube to
> my tinderbox and this is what happens:
> 
> 1. [GOOD] ./tc addPort -b 7.0-STANDARD -O -d mail/roundcube
> 2. [GOOD] tinderbox preserves the OPTIONS files for all dependencies
> 3. [BAD]  tinderbox shows options screen for dependency www/apache22
> 4. [GOOD] I don't want to change the OPTIONS and choose [Cancel]
> 5. [BAD]  tinderbox stops the whole  OPTIONS processing (mail/roundcube too)
> 6. [GOOD] tinderbox adds mail/roundcube to my build 7.0-STANDARD
> 7. [BAD]  there is no OPTIONS file for mail/roundcube (because of 5.)
> 
> So my intention was just to add a new port to my build, preserving
> all existing OPTIONS and only configuring the OPTIONS for the newly
> added port.
> 
> But it shows that this is not possible. I cannot really preserve the 
> old OPTIONS files, because when I do this by skipping an OPTIONS screen
> with [Cancel], tinderbox completely stops OPTIONS processing. Thus the
> newly added port has no OPTIONS file.
> 
> I think tinderbox should behave differently when using the -O switch. 
> It should not show the blue OPTIONS screen when an OPTIONS file for 
> the dependency already exists. 
> I think this is really straightforward, because with -O I already
> told tinderbox to preserve old OPTIONS files. I don't expect
> to see the OPTIONS screen for ports that already have an OPTIONS file
> (that I chose to preserve).
> 
> Let me know what you think about this.

Any word on my patch?

Joe

-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part
URL: <http://marcuscom.com/pipermail/tinderbox-list/attachments/20080915/e4203591/attachment.bin>