Here's a modification that enables "markup" to read compressed logs

[Joe Marcus Clarke]

On 10/25/11 7:07 PM, Beat Gätzi wrote:
> On Oct 26, 2011, at 12:53 AM, John Marino wrote:
>> It seemed a shame that using the web UI meant that you couldn't use the
>> log compression function because all the <log> and <markup> links would
>> be broken.
> 
> It looks like we have bzip2 log support in HEAD but this was never
> merged back to TINDERBOX_3_X:
> http://www.marcuscom.com/pipermail/tinderbox-cvs/2010-May/001429.html
> 
> Joe, should we merge this for 3.4 or wait until the release is done?

Merge it.  It's been in HEAD long enough, and we could use it.

Joe

> 
>> Worse is when there are old, uncompressed logs so that the links pick
>> those up instead of the recent logs when Tinderbox is configured to
>> compress the logs.
>>
>> I have written a modification to moduleLogs.php that will allow the
>> <markup> hyperlinks to load and display the latest log, even if it's
>> compressed.  The code is here:
>>
>> https://github.com/jrmarino/pkgsrc-tinderbox/blob/master/DragonFly/webui/module/moduleLogs.php
>>
>> The raw logs are still "broken" in this respect, but I will change these
>> hyperlinks from loading static files to having a passthrough as the
>> marked-up logs are handled.
>>
>> I think incorporating this improvement to the marked-up log would be
>> nice for the 3.4 release if there's still time.
>>
>> Regards,
>> John
>>
>> P.S. The Tinderbox/pkgsrc is working really well now.  I'll post a
>> screenshot soon.  I'm still finding some kinks here and there due to
>> design differences between the packaging systems.
>>
>> P.P.S. If you don't take this for 3.4, at least add "fclose ($fh)" to
>> the current moduleLogs.php.  The file is opened but never closed there.
> 
> If we don't merge it for 3.4 I will add the "fclose ($fh)" to TINDERBOX_3_X.
> 
> Thanks,
> Beat
> 
>> _______________________________________________
>> tinderbox-list at marcuscom.com mailing list
>> http://marcuscom.com/mailman/listinfo/tinderbox-list
>> To unsubscribe, send any mail to "tinderbox-list-unsubscribe at marcuscom.com"
> 
> 
> _______________________________________________
> tinderbox-list at marcuscom.com mailing list
> http://marcuscom.com/mailman/listinfo/tinderbox-list
> To unsubscribe, send any mail to "tinderbox-list-unsubscribe at marcuscom.com"
> 


-- 
PGP Key : http://www.marcuscom.com/pgp.asc