[RFC] Moving location of options directory

Ade Lovett ade at FreeBSD.org
Tue Jan 8 14:33:14 EST 2013


Back when we added options support for tinderbox, if HOST_WORKDIR was 
set, it'd use that as the base directory.

On reflection, this seems like a bad idea since it prevents the use of a 
truly shared options directory if using multiple discrete machines to 
build things.

The attached patch changes this to use ${pb}/${OPTIONS_DIR} regardless 
of whether HOST_WORKDIR is set.   I've been using this for quite some 
time now, and the impending 4.0 release seems like a good time to chunk 
it in.

Thoughts?

-aDe

-------------- next part --------------
Index: tinderlib.sh
===================================================================
RCS file: /space/cvs/marcuscom-cvs/portstools/tinderbox/lib/tinderlib.sh,v
retrieving revision 1.80
diff -u -1 -r1.80 tinderlib.sh
--- tinderlib.sh	2 Jan 2013 21:18:59 -0000	1.80
+++ tinderlib.sh	8 Jan 2013 19:34:30 -0000
@@ -66,8 +66,3 @@
 			;;
-    "options")		if [ -z "${HOST_WORKDIR}" ]; then
-    			    echo "${pb}/${OPTIONS_DIR}/${what}"
-			else
-			    echo "${HOST_WORKDIR}/options/${what}"
-			fi
-			;;
+    "options")		echo "${pb}/${OPTIONS_DIR}/${what}";;
     "jail")		echo "${pb}/jails/${what}";;


More information about the tinderbox-list mailing list